Skip to content

fix: Remove LooseVersion #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2025
Merged

fix: Remove LooseVersion #115

merged 3 commits into from
Apr 3, 2025

Conversation

@hoxbro
Copy link
Contributor

@hoxbro hoxbro commented Apr 2, 2025

Fixes #109

kernel_version is no longer used, so we can remove the import of LooseVersion.

@peytondmurray
Copy link
Contributor

peytondmurray commented Apr 2, 2025

Thanks for this, I was just running into this on #64. I'm not sure what the intent was in defining kernel_version; I guess for compatibility we could use packaging.version.Version in case someone is making use of it, although I'd be surprised if it was.

@hoxbro
Copy link
Contributor Author

hoxbro commented Apr 3, 2025

It was added in #36 to be compatible with ipykernel 6 and was removed in #93.

Replacing it with packaging.version.Version will still break if people use it, as it no longer works with string equality check. So, I don't think it is worth keeping.

@hoxbro hoxbro mentioned this pull request Apr 3, 2025
Merged
@hoxbro hoxbro requested a review from philippjfr April 3, 2025 13:36
@philippjfr philippjfr merged commit bbd6195 into main Apr 3, 2025
4 checks passed
developers001
developers001 reviewed Aug 30, 2025
View reviewed changes
Copy link

@developers001 developers001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All issues resolveed

developers001
developers001 reviewed Aug 30, 2025
View reviewed changes
Copy link

@developers001 developers001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philippjfr philippjfr Awaiting requested review from philippjfr

1 more reviewer

@developers001 developers001 developers001 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Python>=3.12

5 participants

@hoxbro @peytondmurray @developers001 @philippjfr